Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyoidc and pysaml2 from core #442

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Remove pyoidc and pysaml2 from core #442

wants to merge 11 commits into from

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Aug 18, 2023

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

This PR makes pytest skip tests that are dependent on uninstalled packages. To do this I use an check (importorskip) that comes with pytest.

Also added a missing test for the idpyoidc based OIDC backend.

rohe and others added 11 commits June 8, 2023 09:40
@rohe
New idpyoidc based OAuth2/OIDC backend
baba62d
@rohe
Added error message handling.
d8f0387
@rohe
Updated init attributes.
44d02f2
@rohe
Changes as a result of Ali's testing.
27b8e8d
@rohe
More changes as a result of Ali Haider's testing.
de348c5
@rohe
Example backend used by Ali Haider.
f9fdc5e
@rohe
Started to weed SATOSA core from saml2.
e839448 
Replacing jwkest with cryptojwt.
Making tests that are dependent on pyoidc not be executed if pyoidc is not installed.
@rohe
Added test for idpy-oidc based backend.
ff23b60 
Switched from AES-CBC crypto to AES-GCM.
Replaced dependency on pycryptodomex to cryptojwt.
Refactored idpy_oidc.py to get a create_client function used in testing.
Made pytest skip test modules if a necessary package was not present.
@rohe
Also skip test_idpy_oidc.py if the idpyoidc package is not present.
33fb01d
@c00kiemon5ter @rohe
Improve configuration readability of the primary-identifier plugin
066c045 
Signed-off-by: Ivan Kanakarakis <[email protected]>
@rohe
Merge branch 'master' into rm_saml2_from_core_2
9ccc44c
@c00kiemon5ter c00kiemon5ter self-assigned this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c00kiemon5ter c00kiemon5ter Awaiting requested review from c00kiemon5ter

Assignees

@c00kiemon5ter c00kiemon5ter

Labels
breaking enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohe @c00kiemon5ter